Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have --package usage respect mypy_path #6926

Merged
merged 1 commit into from Jun 20, 2019

Conversation

@abatilo
Copy link
Contributor

commented Jun 2, 2019

Addresses:
#6595

@blueyed

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

Needs a test (#6595 (comment)), but maybe wait for some other feedback first.

@ethanhs ethanhs self-requested a review Jun 3, 2019

@ethanhs

This comment has been minimized.

Copy link
Collaborator

commented Jun 3, 2019

@abatilo I believe you can make a modified version of this test case where you write a mypy.ini in venv_dir and pass that with --config-file to mypy. Leave a message when you are done and I can review this.

@abatilo

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

@ethanhs After much fighting with the CI checks, I think I finally have a test that I can be proud of, and one that did in fact fail before the accompanying change was made. Please let me know if there's anything I need to change!

@ethanhs

This comment has been minimized.

Copy link
Collaborator

commented Jun 12, 2019

@abatilo sorry for the delay, I will review this tomorrow.

@ethanhs
Copy link
Collaborator

left a comment

Thanks so much for your work on this!

@abatilo

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

My first OSS contribution!!! :D

@ethanhs

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2019

Unless someone else wants to review this/has further feedback I will merge this tomorrow.

@abatilo

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

@ethanhs Ping on this.

@ethanhs ethanhs merged commit 6bbc3df into python:master Jun 20, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ethanhs

This comment has been minimized.

Copy link
Collaborator

commented Jun 20, 2019

@abatilo Thank you for your contribution!

PattenR added a commit to PattenR/mypy that referenced this pull request Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.