Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand environment variables in cache_dir config #7022

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@hetmankp
Copy link
Contributor

commented Jun 19, 2019

This further extends parsing of the 'cache_dir' configuration option (as originally introduced by #6651) to do environment variable expansion in addition to user home directory expansion. This makes it much easier to integrate mypy with other tools as well as making it possible to create more generic configuration files.

The 'cache_dir' configuration option will expand environment variables
in addition to the user home directory. This makes it much easier to
integrate with wrapper tools that use mypy.
@hetmankp

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

Hi. Just pinging this thread to get some feedback as per the contributors documentation. Is it preferable to submit an issue linked to this pull request for the discussion?

@JukkaL
JukkaL approved these changes Jul 24, 2019
Copy link
Collaborator

left a comment

This seems reasonable. Thanks for the PR -- and sorry for the delay in reviewing this!

@JukkaL JukkaL merged commit 15c318a into python:master Jul 24, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.