Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slicing tuples with nonliterals #7066

merged 3 commits into from Jun 27, 2019


Copy link

commented Jun 25, 2019

This fixes #7056.

The idea is that we don't know what types a tuple slice will result in, other than a tuple of some sort.

For example, (1,'', 3.3)[:a] could result in Tuple[()], Tuple[int], Tuple[int, str], or Tuple[int, str, float].

I also fixed a typo I noticed in TypeOfAny.

Show resolved Hide resolved mypy/ Outdated

@ethanhs ethanhs requested review from ilevkivskyi and JukkaL Jun 26, 2019

Show resolved Hide resolved mypy/ Outdated

JukkaL approved these changes Jun 27, 2019

Copy link

left a comment

Thanks for the updates! Looks good now.

@JukkaL JukkaL merged commit 0aa1fe2 into master Jun 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@ilevkivskyi ilevkivskyi deleted the tupleindex branch Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.