Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --strict-equality for decorated and aliased __eq__ methods #7156

Merged
merged 2 commits into from Jul 5, 2019

Conversation

@ilevkivskyi
Copy link
Collaborator

commented Jul 5, 2019

Fixes #7035

The fix is straightforward: we use get() instead of get_method() and check for more symbol kinds.

@ilevkivskyi ilevkivskyi requested a review from JukkaL Jul 5, 2019

@JukkaL

JukkaL approved these changes Jul 5, 2019

Copy link
Collaborator

left a comment

Looks good! I wonder if we should deprecate get_method, since it seems pretty error-prone.

@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 5, 2019

Looks good! I wonder if we should deprecate get_method, since it seems pretty error-prone.

I think yes, but it may require some work because it is still used in 12 places (and in some plugins).

@ilevkivskyi ilevkivskyi merged commit 5002277 into python:master Jul 5, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ilevkivskyi ilevkivskyi deleted the ilevkivskyi:fix-streq-deco branch Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.