Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always erase last known value from instances when using binder or partial types #7354

Merged
merged 3 commits into from Aug 16, 2019

Conversation

@ilevkivskyi
Copy link
Collaborator

commented Aug 16, 2019

See the test cases for simplified example of currently problematic behaviour when using --strict-equality.

@ilevkivskyi ilevkivskyi requested a review from Michael0x2a Aug 16, 2019
Copy link
Collaborator

left a comment

LGTM!

Ivan Levkivskyi added 2 commits Aug 16, 2019
Ivan Levkivskyi
Ivan Levkivskyi
@ilevkivskyi ilevkivskyi changed the title Always erase last known value from instances when using binder Always erase last known value from instances when using binder or partial types Aug 16, 2019
@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 16, 2019

Hm, this is one more case when binder and partial types share bugs. Looks like another argument in favour of trying to combine them.

@ilevkivskyi ilevkivskyi merged commit 858a243 into python:master Aug 16, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ilevkivskyi ilevkivskyi deleted the ilevkivskyi:binder-literal branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.