Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix tests on 3.8 and enable it in CI #7421
A couple things were needed to fix the tests:
Pleasantly no actually code issues needed to be fixed.
A couple things were needed to fix the tests: * mypy failed because ast.Str.kind doesn't exist * flake8 run with python3.8 now reports decorated function redefinitions on the line of the function definition and not the first decorator which means we would need to noqa overloads *twice*. I already found it really annoying so I disabled the check. (But it looks like the next version of pyflakes will fix the overload issue.) * pythoneval tests failed due to a bunch of deprecation warnings for `@coroutine` which I silenced. * One walrus test had broken because it hasn't been run * The docstring of `object` changed and we were printing it in an eval test * The column of something changed in one test Pleasantly no actually code issues needed to be fixed.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.