Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on 3.8 and enable it in CI #7421

Merged
merged 2 commits into from Aug 30, 2019

Conversation

@msullivan
Copy link
Collaborator

commented Aug 29, 2019

A couple things were needed to fix the tests:

  • mypy failed because ast.Str.kind doesn't exist
  • flake8 run with python3.8 now reports decorated function
    redefinitions on the line of the function definition and not the
    first decorator which means we would need to noqa overloads twice.
    I already found it really annoying so I disabled the check.
    (But it looks like the next version of pyflakes will fix the overload
    issue.)
  • pythoneval tests failed due to a bunch of deprecation warnings for
    @coroutine which I silenced.
  • One walrus test had broken because it hasn't been run
  • The docstring of object changed and we were printing it in an eval test
  • The column of something changed in one test

Pleasantly no actually code issues needed to be fixed.

A couple things were needed to fix the tests:
 * mypy failed because ast.Str.kind doesn't exist
 * flake8 run with python3.8 now reports decorated function
   redefinitions on the line of the function definition and not the
   first decorator which means we would need to noqa overloads *twice*.
   I already found it really annoying so I disabled the check.
   (But it looks like the next version of pyflakes will fix the overload
   issue.)
 * pythoneval tests failed due to a bunch of deprecation warnings for
   `@coroutine` which I silenced.
 * One walrus test had broken because it hasn't been run
 * The docstring of `object` changed and we were printing it in an eval test
 * The column of something changed in one test

Pleasantly no actually code issues needed to be fixed.
@msullivan msullivan requested review from JukkaL, Michael0x2a and ilevkivskyi Aug 29, 2019
mypy/types.py Outdated Show resolved Hide resolved
@JukkaL
JukkaL approved these changes Aug 30, 2019
Copy link
Collaborator

left a comment

Thanks for enabling 3.8 on CI! This will make us better prepared for the 3.8 release.

@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator

commented Aug 30, 2019

A random idea: What about also running mypyc compiled tests on Python 3.8 (In addition to 3.7)?

@msullivan

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 30, 2019

I'm not sure if we want to add another full run build?

@msullivan msullivan merged commit 162df36 into master Aug 30, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@msullivan msullivan deleted the 3.8 branch Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.