Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Bugfix 7514 #7515
msullivan left a comment
Sorry for the long delay on this, but I think the same concern you had about the existing code had us confused too.
The new code looks good. A lot better than the old code.
From looking a bit at git blame I think that the original code predated
I think this is a nice improvement and the fact that it actually fixes bugs is gravy.
... but also maybe I'm wrong and there is something subtle here and I'll have to revert once we discover problems internally. But I don't think so.