Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 7514 #7515

Merged
merged 3 commits into from Oct 3, 2019

Conversation

@patrickw276
Copy link
Contributor

patrickw276 commented Sep 14, 2019

Copy link
Collaborator

msullivan left a comment

Sorry for the long delay on this, but I think the same concern you had about the existing code had us confused too.

The new code looks good. A lot better than the old code.

From looking a bit at git blame I think that the original code predated Type and Union and so was expressed in a much less elegant way. The TypeType check got added last year and was done the way it was because it matched the code.

I think this is a nice improvement and the fact that it actually fixes bugs is gravy.

... but also maybe I'm wrong and there is something subtle here and I'll have to revert once we discover problems internally. But I don't think so.

Thanks!

@msullivan msullivan merged commit 37e9a98 into python:master Oct 3, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.