Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve missing import message #7698

Merged

Conversation

@Lewiscowles1986
Copy link
Contributor

Lewiscowles1986 commented Oct 11, 2019

It can be difficult to understand the missing module error message at times.

Changes

Cannot find module named '{}'

to

Cannot find implementation or library stub for module named '{}'

This improves #4542

Great thanks to all that participated in that discussion, this is all of our work.

@JukkaL

@Lewiscowles1986 Lewiscowles1986 force-pushed the Lewiscowles1986:improve-missing-import-message branch from 7e15a0b to bbb4871 Oct 11, 2019
@Lewiscowles1986 Lewiscowles1986 marked this pull request as ready for review Oct 11, 2019
Copy link
Collaborator

msullivan left a comment

This seems reasonable to me, assuming we're hapy with the wording. @JukkaL?

@JukkaL

This comment has been minimized.

Copy link
Collaborator

JukkaL commented Oct 28, 2019

Looks good!

@JukkaL JukkaL merged commit 70f2857 into python:master Oct 28, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.