Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix __init_subclass__ type check #7723

Merged
merged 1 commit into from Oct 16, 2019

Conversation

@ilevkivskyi
Copy link
Collaborator

ilevkivskyi commented Oct 16, 2019

Fixes #7722

This skips checking class keywords against __init_subclass__ for:

  • Classes with custom metaclasses, because they can pop the keywords before calling super().
  • Classes that are special forms, like TypedDict etc.
Ivan Levkivskyi
@ilevkivskyi ilevkivskyi requested a review from msullivan Oct 16, 2019
@msullivan

This comment has been minimized.

Copy link
Collaborator

msullivan commented Oct 16, 2019

Yeah, good catch. This will get cherry picked.

@msullivan msullivan merged commit 222b14d into python:master Oct 16, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
msullivan added a commit that referenced this pull request Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.