Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix internal error inheriting a dataclass duplicated field #7792 #7808
Conversation
The error was:
```
(attr,) = [a for a in all_attrs if a.name == name]
ValueError: not enough values to unpack (expected 1, got 0)
```
No need to enter in the `else` if all_attrs is empty
And don't assume that there is a matching attr in all_attr
|
Thanks for the fix! Looks good. The first error message looks a bit odd but it's a much less serious issue than a crash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vbarbaresi commentedOct 28, 2019
The error was:
No need to enter in the
elseif all_attrs is emptyAnd don't assume that the matching attr exists in
all_attr