Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 7807 #7820

Merged
merged 2 commits into from Oct 30, 2019

Conversation

@goodmami
Copy link
Contributor

goodmami commented Oct 30, 2019

Commit a8c7947 removed the old parser after the new one had taken
over, but the ability to use mypy.parse as a script for dumping
parse trees was also removed, perhaps by accident. This commit adds
that functionality back as the misc/dump-ast.py script.

This partially resolves issue #7807. What remains is editing the wiki accordingly.

goodmami added 2 commits Oct 30, 2019
Commit a8c7947 removed the old parser after the new one had taken
over, but the ability to use `mypy.parse` as a script for dumping
parse trees was also removed, perhaps by accident. This commit adds
that functionality back as a script under `misc/`.
@JukkaL
JukkaL approved these changes Oct 30, 2019
Copy link
Collaborator

JukkaL left a comment

Thanks for adding the AST dump functionality back! This will helpful for new contributors, in particular. Looks good.

Optionally, it would nice to have a few test cases for this (in a separate PR), but since this is a developer-only utility, it's not very important.

@JukkaL JukkaL merged commit 270afec into python:master Oct 30, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@goodmami goodmami deleted the goodmami:fix-7807 branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.