Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use union component as a self-type in class methods #7822

Merged
merged 1 commit into from Oct 30, 2019

Conversation

@ilevkivskyi
Copy link
Collaborator

ilevkivskyi commented Oct 30, 2019

Fixes #7821

The same logic is already used for normal methods, I think class methods should be no different.

@ilevkivskyi ilevkivskyi requested a review from JukkaL Oct 30, 2019
@JukkaL
JukkaL approved these changes Oct 30, 2019
Copy link
Collaborator

JukkaL left a comment

LGTM!

@ilevkivskyi ilevkivskyi merged commit 7e7b1e4 into python:master Oct 30, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ilevkivskyi ilevkivskyi deleted the ilevkivskyi:fix-union-self-classmethod branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.