Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix crashes in astdiff when sorting union items #7842
Conversation
Previously the snapshots could be unsortable, since the snapshot tuples could have inconsistent types. This attemps to make the types in tuples predictable based on the tuple prefix. More formally, consider these two snapshot tuples: (x1, ..., xn, xn+1, ...) (y1, ..., yn, yn+1, ...) If (x1, ..., xn) == (y1, ..., yn), xn+1 and yn+1 must be comparable. Attempt to fix #7834.
|
Thanks! Just one question, otherwise LG. |
| @@ -282,9 +292,9 @@ def visit_deleted_type(self, typ: DeletedType) -> SnapshotItem: | |||
|
|
|||
| def visit_instance(self, typ: Instance) -> SnapshotItem: | |||
| return ('Instance', | |||
| typ.type.fullname(), | |||
| encode_optional_str(typ.type.fullname()), | |||
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
Nov 1, 2019
Collaborator
Doesn't this mean there is a bug elsewhere? Maybe we shouldn't mask it (especially if there is no repro)?
This comment has been minimized.
This comment has been minimized.
JukkaL
Nov 1, 2019
Author
Collaborator
I think that this is not a great place to detect the bug, since the traceback won't tell much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
JukkaL commentedNov 1, 2019
Previously the snapshots could be unsortable, since the snapshot
tuples could have inconsistent types. This attemps to make the types
in tuples predictable based on the tuple prefix.
More formally, consider these two snapshot tuples:
If
(x1, ..., xn)==(y1, ..., yn),xn+1andyn+1must becomparable.
Attempt to fix #7834.