Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure type inference works for literals against protocols #7882

Merged
merged 2 commits into from Nov 5, 2019

Conversation

@ilevkivskyi
Copy link
Collaborator

ilevkivskyi commented Nov 5, 2019

This is mostly important for builtin functions like round(), abs(), etc., that currently don't work well when a literal is passed to it.

@ilevkivskyi ilevkivskyi requested a review from Michael0x2a Nov 5, 2019
Ivan Levkivskyi
Copy link
Collaborator

Michael0x2a left a comment

It looks like there's a CI failure? Not really sure what's happening there.

But otherwise LGTM.

@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator Author

ilevkivskyi commented Nov 5, 2019

Looks like an AppVeyor bug, I will try closing and re-opening.

@ilevkivskyi ilevkivskyi closed this Nov 5, 2019
@ilevkivskyi ilevkivskyi reopened this Nov 5, 2019
@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator Author

ilevkivskyi commented Nov 5, 2019

It didn't really help, but at least I can see that one of the builds on AppVeyor passed, I will merge now since this looks low risk.

@ilevkivskyi ilevkivskyi merged commit 0b2cf27 into python:master Nov 5, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@ilevkivskyi ilevkivskyi deleted the ilevkivskyi:fix-literal-protocol branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.