Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiled dmypy on Windows #7929

Merged
merged 1 commit into from Nov 12, 2019

Conversation

@msullivan
Copy link
Collaborator

msullivan commented Nov 12, 2019

The issue was that the mechanism for transmitting Options to the daemon
on Windows used snapshot/apply_changes and those don't play well with
read-only attributes when compiled.

I've fixed this in the most expedient way for now but will do some
follow ups to clean up this mechanism and hopefully test this on
Windows in CI.

The issue was that the mechanism for transmitting Options to the daemon
on Windows used snapshot/apply_changes and those don't play well with
read-only attributes when compiled.

I've fixed this in the most expedient way for now but will do some
follow ups to clean up this mechanism and hopefully test this on
Windows in CI.
@msullivan msullivan requested review from JukkaL and ilevkivskyi Nov 12, 2019
@msullivan

This comment has been minimized.

Copy link
Collaborator Author

msullivan commented Nov 12, 2019

This would be worth a point release except that the paucity of reports makes me suspect nobody would care? I don't know.

Copy link
Collaborator

ilevkivskyi left a comment

Thanks for the quick fix!

@msullivan msullivan merged commit 91409ff into master Nov 12, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@msullivan msullivan deleted the fix-windows branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.