Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin invocation on classmethod calls through `Type` #7969

Merged
merged 1 commit into from Nov 18, 2019

Conversation

@msullivan
Copy link
Collaborator

msullivan commented Nov 18, 2019

We weren't computing the proper fullname through TypeType (only
through type obj callables. Maybe we should get rid of those...)

This fixes these getting missed by suggestions.

We weren't computing the proper fullname through TypeType (only
through type obj callables. Maybe we should get rid of those...)

This fixes these getting missed by suggestions.
@msullivan msullivan requested review from JukkaL and ilevkivskyi Nov 18, 2019
Copy link
Collaborator

ilevkivskyi left a comment

Maybe we should get rid of those...

There was an idea to unify class callables and Type[...] but I think it is still not possible (or at least non-trivial).

@msullivan msullivan merged commit 0da67dd into master Nov 18, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@msullivan msullivan deleted the suggest-classmethod-type branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.