Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke get_dynamic_class_hook on method calls #7990

Merged
merged 2 commits into from Nov 23, 2019

Conversation

@syastrov
Copy link
Contributor

syastrov commented Nov 21, 2019

I would like to see this merged, and don't know if @mkurnikov has time to follow up, so I decided to make a PR based on his, which implements the suggestions from the review comments.
#7704

@ilevkivskyi I have implemented your suggestions (as far as I understand them), but I'm not sure how to test that they are working.

Fixes #7266

mkurnikov and others added 2 commits Oct 11, 2019
- A RefExpr (including MemberExpr) with a non-None full name should always take precedence.
- Check that MyManager can be used as an annotation for a function argument.
Copy link
Collaborator

ilevkivskyi left a comment

Thanks, looks good!

@ilevkivskyi ilevkivskyi merged commit 20b60b5 into python:master Nov 23, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.