Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meaningful message with long tuple initializer #7995

Conversation

@TH3CHARLie
Copy link
Contributor

TH3CHARLie commented Nov 21, 2019

resolves #7977

Current format of error message(especially for item-by-item case) need discussion

request for review if you are free @JukkaL @ilevkivskyi

@TH3CHARLie

This comment has been minimized.

Copy link
Contributor Author

TH3CHARLie commented Nov 22, 2019

Well, Python3.8 tests continue to fail because their errors are reported one row different from previous version.

Copy link
Collaborator

JukkaL left a comment

Thanks for the PR! I left a few commits about code style and formatting of the messages. You can perhaps avoid the Python 3.8 error by reformatting the code a bit so that all Python versions report the same line. Python 3.8 changed the locations of various AST nodes a bit.

test-data/unit/check-tuples.test Outdated Show resolved Hide resolved
mypy/checker.py Outdated Show resolved Hide resolved
@TH3CHARLie TH3CHARLie requested a review from JukkaL Nov 22, 2019
@TH3CHARLie

This comment has been minimized.

Copy link
Contributor Author

TH3CHARLie commented Nov 29, 2019

@JukkaL Hi, if you have any time could you please review this as I think it’s nearly finished with some minor fixes maybe

Copy link
Collaborator

JukkaL left a comment

Thanks for the updates! I have some minor comments, but otherwise looks good. This should be ready to merge soon.

mypy/checker.py Outdated Show resolved Hide resolved
mypy/checker.py Outdated Show resolved Hide resolved
mypy/checker.py Outdated Show resolved Hide resolved
mypy/checker.py Outdated Show resolved Hide resolved
mypy/checker.py Outdated Show resolved Hide resolved
mypy/checker.py Outdated Show resolved Hide resolved
mypy/checker.py Outdated Show resolved Hide resolved
@TH3CHARLie TH3CHARLie requested a review from JukkaL Dec 3, 2019
@JukkaL
JukkaL approved these changes Dec 3, 2019
Copy link
Collaborator

JukkaL left a comment

Thanks! Looks good now!

@JukkaL JukkaL merged commit 3930bbf into python:master Dec 3, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TH3CHARLie

This comment has been minimized.

Copy link
Contributor Author

TH3CHARLie commented Dec 3, 2019

Thanks for the review!

@TH3CHARLie TH3CHARLie deleted the TH3CHARLie:meaningful-message-with-long-tuple-initializer branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.