Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend typing_extensions instead of mypy_extensions for TypedDict #8023

Merged

Conversation

@ilevkivskyi
Copy link
Collaborator

ilevkivskyi commented Nov 27, 2019

Now that TypedDict is an official feature I think this would make sense.

@ilevkivskyi ilevkivskyi requested a review from JukkaL Nov 27, 2019
@JukkaL
JukkaL approved these changes Nov 27, 2019
Copy link
Collaborator

JukkaL left a comment

Thanks! What about also documenting that in Python 3.8 TypedDict can be imported from typing?

@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator Author

ilevkivskyi commented Nov 27, 2019

What about also documenting that in Python 3.8 TypedDict can be imported from typing?

OK, I will add a short note about this (Python 3.8 is still new so I think we can use typing_extensions in the examples).

@ilevkivskyi ilevkivskyi merged commit f78effd into python:master Nov 27, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ilevkivskyi ilevkivskyi deleted the ilevkivskyi:typing-extensions-typeddict-docs branch Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.