Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when using pyd file as stubgen #8063

Merged
merged 3 commits into from Dec 3, 2019

Conversation

@TH3CHARLie
Copy link
Contributor

TH3CHARLie commented Dec 3, 2019

resolves #8035

Copy link
Collaborator

ethanhs left a comment

Thank you for the PR! I have one suggestion but otherwise looks good.

mypy/build.py Show resolved Hide resolved
@ethanhs
ethanhs approved these changes Dec 3, 2019
Copy link
Collaborator

ethanhs left a comment

Excellent, thank you!

@TH3CHARLie

This comment has been minimized.

Copy link
Contributor Author

TH3CHARLie commented Dec 3, 2019

Thanks for the review

@JukkaL JukkaL merged commit e05bd1c into python:master Dec 3, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TH3CHARLie TH3CHARLie deleted the TH3CHARLie:better-error-msg-for-pyd-file branch Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.