Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always freeze type variables that were previously freshen #8075

Merged
merged 1 commit into from Dec 4, 2019

Conversation

@ilevkivskyi
Copy link
Collaborator

ilevkivskyi commented Dec 4, 2019

Fixes #8072

The fix is straightforward, just copy the logic from the working case (see last test) to two other code paths. Note that only two first cases I added crash on master, but I also add the last one for completeness because I didn't find a similar existing test case.

@ilevkivskyi ilevkivskyi requested a review from JukkaL Dec 4, 2019
@JukkaL
JukkaL approved these changes Dec 4, 2019
Copy link
Collaborator

JukkaL left a comment

Thanks for the quick fix!

@ilevkivskyi ilevkivskyi merged commit ce8951e into python:master Dec 4, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ilevkivskyi ilevkivskyi deleted the ilevkivskyi:fix-serialize-generic branch Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.