Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly push scope when checking lambda expressions #8080

Merged
merged 2 commits into from Dec 5, 2019

Conversation

@ilevkivskyi
Copy link
Collaborator

ilevkivskyi commented Dec 4, 2019

Fixes #8079

Previously function scope was pushed inconsistently in two branches of visit_lambda_expr() (it was only pushed in the second branch by check_func_item()). I believe there is still a small inconsistency, although I wasn't able to trigger a corresponding crash, I added a TODO about this.

@ilevkivskyi ilevkivskyi requested a review from JukkaL Dec 4, 2019
@JukkaL
JukkaL approved these changes Dec 5, 2019
Copy link
Collaborator

JukkaL left a comment

Thanks for the quick fix!

@JukkaL JukkaL merged commit 130663b into python:master Dec 5, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.