Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inferencing type reference of abstract class inferred from concrete type values #8096

Merged
merged 4 commits into from Dec 7, 2019

Conversation

@TH3CHARLie
Copy link
Contributor

TH3CHARLie commented Dec 6, 2019

resolves #8050, following the purposed solution 2 in #8050 (comment) and using the implementation purposed in #8050 (comment)

Currently, no testcase with regard to meet of callables is available, since I'm not sure what a proper testcase would be.

@JukkaL
JukkaL approved these changes Dec 6, 2019
Copy link
Collaborator

JukkaL left a comment

Thanks, looks good! I checked that this doesn't generate new errors in our internal codebase S.

@ilevkivskyi Do you want to have a look since you proposed this change?

Copy link
Collaborator

ilevkivskyi left a comment

Looks good, but I have a suggestion about the comments.

mypy/join.py Outdated Show resolved Hide resolved
TH3CHARLie added 2 commits Dec 7, 2019
@ilevkivskyi ilevkivskyi merged commit 9d10a3e into python:master Dec 7, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TH3CHARLie TH3CHARLie deleted the TH3CHARLie:fix-8050 branch Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.