Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in container check logic #8232

Merged

Conversation

@Michael0x2a
Copy link
Collaborator

Michael0x2a commented Jan 2, 2020

This PR fixes the crash reported in #8230 by replacing the 'pass' with the 'continue', as suggested.

However, it does not fix the underlying root cause -- I don't think I actually understand the relevant pieces of code enough to feel confident volunteering a fix. So, I settled for this more limited fix.

Basically, it seems this bug is due to how we try inferring the type of the lambda in multiple passes to resolve the types. We pencil in an ErasedType during the first pass -- and then subsequently crash when attempting to type check the body during that pass. I'll leave more details about this in the linked issue.

Michael0x2a added 2 commits Jan 2, 2020
This PR fixes the crash reported in #8230,
by replacing the 'pass' with the 'continue', as suggested.

However, it does *not* fix the underlying root cause -- I don't think
I actually understand the relevant pieces of code enough to feel
confident volunteering a fix. So, I settled for just fixing the
regression.

Basically, it seems this bug is due to how we try inferring the type
of the lambda in multiple passes to resolve the types. We pencil in an
ErasedType during the first pass -- and then subsequently crash when
attempting to type check the body during that pass. I'll leave more
details about this in the linked issue.
Copy link
Collaborator

ilevkivskyi left a comment

Thanks! This looks good for now.

@ilevkivskyi ilevkivskyi merged commit cdd91ba into python:master Jan 3, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sthagen added a commit to sthagen/mypy that referenced this pull request Jan 4, 2020
Fix regression in container check logic (python#8232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.