Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect "unused 'type: ignore' comment" error log coloring #8248

Merged
merged 1 commit into from Jan 6, 2020

Conversation

@TH3CHARLie
Copy link
Contributor

TH3CHARLie commented Jan 6, 2020

fixes #8242

Original error code indexing is assuming all `msg's included a '[', which clearly fails on "unused 'type: ignore' comment", this PR provides correct string finding and substring indexing thus a correct colorization.

However, it also seems meaningful to add an error code for this error. Suggestions are welcomed.

Copy link
Collaborator

msullivan left a comment

Thanks!

@msullivan msullivan merged commit 7c5e69b into python:master Jan 6, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TH3CHARLie TH3CHARLie deleted the TH3CHARLie:fix-8242 branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.