Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new error code for unreachable statement #8312

Merged
merged 4 commits into from Jan 23, 2020
Merged

Conversation

@DenisOH
Copy link
Contributor

DenisOH commented Jan 22, 2020

Closes #8190.
This introduces a new error for unreachable_statement.

@DenisOH DenisOH requested a review from ilevkivskyi Jan 22, 2020
Copy link
Collaborator

Michael0x2a left a comment

Thanks for the PR!

I had a few suggestions, but this generally looks good.

Could you also make sure to add a section for this new error code in https://github.com/python/mypy/blob/master/docs/source/error_code_list2.rst? It doesn't need to be anything complicated -- just a short description and example would be great.

mypy/messages.py Show resolved Hide resolved
@DenisOH

This comment has been minimized.

Copy link
Contributor Author

DenisOH commented Jan 23, 2020

@Michael0x2a Sure!

@DenisOH DenisOH requested review from Michael0x2a and removed request for ilevkivskyi Jan 23, 2020
DenisOH and others added 3 commits Jan 23, 2020
Copy link
Collaborator

Michael0x2a left a comment

Thanks! Merging now.

Note: I also tweaked your PR clarify this error is also shown for unreachable expressions; hope you don't mind.

@Michael0x2a Michael0x2a merged commit f3c57e5 into python:master Jan 23, 2020
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@DenisOH DenisOH deleted the DenisOH:8190 branch Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.