Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support typing.Annotated on top of typing_extensions.Annotated #8371

Merged
merged 1 commit into from Feb 6, 2020

Conversation

@jstasiak
Copy link
Contributor

jstasiak commented Feb 5, 2020

This is to handle PEP 593 support recently merged into CPython[1].

I'm wondering what to do with this test-wise, as https://github.com/python/mypy/blob/39d6bde2ec7063bd2cec42cce9295479e744bcc7/test-data/unit/check-annotated.test is full of imports from typing_extensions and ideally, when running mypy tests on CPython nightly, tests would also import Annotated from typing. But maybe it's not worth it right now.

[1] python/cpython#18260

This is to handle PEP 593 support recently merged into CPython[1].

[1] python/cpython#18260
@msullivan msullivan merged commit 8888b1a into python:master Feb 6, 2020
4 checks passed
4 checks passed
build (windows-py37-32)
Details
build (windows-py37-64)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.