Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section for incompatible overrides #8377

Merged
merged 3 commits into from Feb 21, 2020
Merged

Conversation

@rahulrj
Copy link
Contributor

rahulrj commented Feb 6, 2020

This is according to changes suggested in #7994
I will work further to update the code and point to this documentation when mypy throws error.

rahulrj added 2 commits Feb 6, 2020
This is according to changes suggested in #7994
@rahulrj rahulrj requested review from ilevkivskyi, JelleZijlstra and JukkaL Feb 6, 2020
@msullivan

This comment has been minimized.

Copy link
Collaborator

msullivan commented Feb 6, 2020

Is there a simpler example that could be used, without TypedDicts? Ideally using built-in types?

@rahulrj

This comment has been minimized.

Copy link
Contributor Author

rahulrj commented Feb 6, 2020

@msullivan updated the code to include a simpler example. Would that work?

@msullivan msullivan merged commit 88e8f03 into python:master Feb 21, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.