-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PEP 11: define tiered platform support #2442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
20a0076
PEP 11: define tiered platform support
brettcannon 75533cb
Clarify "CPython" vs "Python"
brettcannon 1797984
Apply suggestions from code review
brettcannon 34c5971
Escape markup
brettcannon 5ed886a
Fix a bad table format
brettcannon b3a76a3
Tweak formatting
brettcannon 96d2d43
Add Petr and Victor as appropriate
brettcannon 54e8c8a
Apply suggestions from code review
brettcannon e777069
add myself to amd64 linux clang
gpshead bf939be
Update pep-0011.txt
brettcannon d75b36f
Merge branch 'main' into supported-platforms
brettcannon a44e26b
Merge branch 'main' into supported-platforms
brettcannon f2fb01f
Add the vendor part of the tag
brettcannon e729642
Merge branch 'python:main' into supported-platforms
brettcannon 7e214ab
Add a tier 3
brettcannon 8d33d2c
Fix a spelling mistake
brettcannon bc44280
Fix a grammatical mistake
brettcannon 4e29215
add Raspbian to Tier 3
gpshead 8fed208
correct the raspbian triple to match configure
gpshead d2f7c41
Merge branch 'main' into supported-platforms
brettcannon 5d9aba7
Update pep-0011.txt
brettcannon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that buildbot URLs are reliable. In the past, some ids changed. Moreover, an URL is not easy to read.
Can you either replace the URL with the buildbot name, or add a label to the URL?
For example, replace
https://buildbot.python.org/all/#/builders/125withaarch64 Fedora Stable 3.x.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or better yet (and per PEP 12),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CAM-Gerlach that suggestion doesn't work since Victor's worry is about URL stability.
@vstinner what I can do is once this update goes in have a
tier-2label added to the appropriate buildbots and then simply link to that label.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that; I thought by "add a label to the URL" he meant using a link with the buildbot name as descriptive link text,
aarch64 Fedora Stable 3.x, so it could still be located by name if its URL changes, but I'm guessing its referring to something else with the buildbots I'm unfamiliar with?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He's referring to the labels you can apply to individual buildbots and then pull up a list of them, e.g. all of the 3.10 buildbots can be found with the
3.10label at https://buildbot.python.org/all/#/builders?tags=%2B3.10 .There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, thanks 👍