Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 740: initial feedback #3637

Merged
merged 4 commits into from Feb 10, 2024
Merged

Conversation

woodruffw
Copy link
Contributor

@woodruffw woodruffw commented Jan 30, 2024

Initial feedback from https://discuss.python.org/t/pep-740-index-support-for-digital-attestations/44498:

  • Adds a point with the JSON API version bump (consistent with PEP 700, which bumped the minor version for a backwards-compatible change)
  • Adds additional motivation/rationale context

馃摎 Documentation preview 馃摎: https://pep-previews--3637.org.readthedocs.build/

Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a PEP editor perspective

Copy link

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

peps/pep-0740.rst Outdated Show resolved Hide resolved
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
@hugovk
Copy link
Member

hugovk commented Feb 10, 2024

@woodruffw Would you like to wait for sponsor @dstufft to review, or are you ready to merge?

@woodruffw
Copy link
Contributor Author

@woodruffw Would you like to wait for sponsor @dstufft to review, or are you ready to merge?

I'm ready for merge! I'm always happy to do additional PRs as needed, so I'd prefer to get this one in 馃檪

@hugovk hugovk merged commit 708a729 into python:main Feb 10, 2024
6 checks passed
@woodruffw woodruffw deleted the ww/740-feedback branch February 10, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants