Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 8 Explicitly State Variable Names convention? #535 #545

Merged
merged 2 commits into from Jan 17, 2018

Conversation

@Carl-Ty
Copy link
Contributor

Carl-Ty commented Jan 17, 2018

There is a response in StackOverflow to the question: What is the naming convention in Python for variable and function names?. It says see PEP 8 and makes the statement "Use the function naming rules: lowercase with words separated by underscores as necessary to improve readability."

That statement is found in other sources and confirmed by experienced Python programmers. But, PEP 8 does not yet support that statement.

@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Jan 17, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@warsaw

This comment has been minimized.

Copy link
Member

warsaw commented Jan 17, 2018

@Carl-Ty - Please do sign the CLA so I can merge this. I noticed one thing in the change that needs to be fixed. Should be easy.

@@ -914,12 +914,14 @@ older convention of prefixing such globals with an underscore (which
you might want to do to indicate these globals are "module
non-public").

Function Names
Function and variable names
~~~~~~~~~~~~~~

This comment has been minimized.

Copy link
@warsaw

warsaw Jan 17, 2018

Member

Oops, sorry, these squigglies need to be extended. They should underline the full header text.

Copy link
Member

warsaw left a comment

The header underline needs extending.

@Carl-Ty

This comment has been minimized.

Copy link
Contributor Author

Carl-Ty commented Jan 17, 2018

I signed up for CLA, hopefully successfully.

@warsaw
warsaw approved these changes Jan 17, 2018
Copy link
Member

warsaw left a comment

Looks great, thanks!

@warsaw warsaw merged commit e0436e9 into python:master Jan 17, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.