Skip to content

Conversation

@carltyndall
Copy link

There is a response in StackOverflow to the question: What is the naming convention in Python for variable and function names?. It says see PEP 8 and makes the statement "Use the function naming rules: lowercase with words separated by underscores as necessary to improve readability."

That statement is found in other sources and confirmed by experienced Python programmers. But, PEP 8 does not yet support that statement.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@warsaw
Copy link
Member

warsaw commented Jan 17, 2018

@Carl-ty - Please do sign the CLA so I can merge this. I noticed one thing in the change that needs to be fixed. Should be easy.

pep-0008.txt Outdated

Function Names
Function and variable names
~~~~~~~~~~~~~~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry, these squigglies need to be extended. They should underline the full header text.

Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header underline needs extending.

@carltyndall
Copy link
Author

I signed up for CLA, hopefully successfully.

Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@warsaw warsaw merged commit e0436e9 into python:master Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants