Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 440: regex should not permit Unicode [Nd] characters #966

Merged
merged 2 commits into from Apr 7, 2019
Merged

PEP 440: regex should not permit Unicode [Nd] characters #966

merged 2 commits into from Apr 7, 2019

Conversation

RazerM
Copy link
Contributor

@RazerM RazerM commented Mar 30, 2019

Example of old behaviour:

>>> is_canonical('1٤')
True

@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Mar 30, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Contributor

@ncoghlan ncoghlan left a comment

Good catch - this was the actual expected behaviour, but the PEP didn't say it explicitly (it was only implied by the version parsing regex in Appendix B)

@ncoghlan ncoghlan merged commit 1dd991e into python:master Apr 7, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants