From 5bfd6a1f8805ce30220d94c709c187b50b350b82 Mon Sep 17 00:00:00 2001 From: Rafael Fontenelle Date: Thu, 11 Sep 2025 21:45:48 -0300 Subject: [PATCH 1/2] Prevent failure on missing Last-Translator field --- scripts/generate_commit_msg.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/scripts/generate_commit_msg.py b/scripts/generate_commit_msg.py index 16b0b2a20..1b3bf6e3e 100755 --- a/scripts/generate_commit_msg.py +++ b/scripts/generate_commit_msg.py @@ -52,9 +52,14 @@ def generate_commit_msg(): or old_entries[entry.msgid] != entry.msgstr ): translator = new_po.metadata.get("Last-Translator") - translator = translator.split(",")[0].strip() + # Prevent failure on missing Last-Translator field. + # Transifex only adds Last-Translator if someone from + # the team translated. If it was uploaded by an account + # that is not in the team, this field will be missing. if translator: - translators.add(f"Co-Authored-By: {translator}") + translator = translator.split(",")[0].strip() + if translator: + translators.add(f"Co-Authored-By: {translator}") break print("Update translation\n\n" + "\n".join(translators)) From 49c672f197741603dd4e61644af99aae47f15450 Mon Sep 17 00:00:00 2001 From: Rafael Fontenelle Date: Thu, 11 Sep 2025 22:00:17 -0300 Subject: [PATCH 2/2] Refactor to remove clunky double condition check --- scripts/generate_commit_msg.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/scripts/generate_commit_msg.py b/scripts/generate_commit_msg.py index 1b3bf6e3e..504e24e3c 100755 --- a/scripts/generate_commit_msg.py +++ b/scripts/generate_commit_msg.py @@ -51,15 +51,15 @@ def generate_commit_msg(): entry.msgid not in old_entries or old_entries[entry.msgid] != entry.msgstr ): - translator = new_po.metadata.get("Last-Translator") # Prevent failure on missing Last-Translator field. # Transifex only adds Last-Translator if someone from # the team translated. If it was uploaded by an account - # that is not in the team, this field will be missing. + # that is not in the team, this field will be missing. + translator = ( + (new_po.metadata.get("Last-Translator") or "").split(",")[0].strip() + ) if translator: - translator = translator.split(",")[0].strip() - if translator: - translators.add(f"Co-Authored-By: {translator}") + translators.add(f"Co-Authored-By: {translator}") break print("Update translation\n\n" + "\n".join(translators)) @@ -84,7 +84,7 @@ def chdir(path: Path): parser.add_argument( "path", type=Path, - nargs='?', + nargs="?", default=".", help="Path to the Git repository (default: current directory)", )