remove feedback capability (issue #65) #194

Merged
merged 1 commit into from Feb 25, 2014

2 participants

@benjaminp

No description provided.

@birkenfeld birkenfeld commented on the diff Feb 25, 2014
static/sass/mq.css
@@ -525,7 +525,7 @@ html[xmlns] .slides { display: block; }
/* We do this more explictly (the descendant selector) to avoid also styling links in the Supernav content */ }
.main-navigation .tier-1 > a, .main-navigation .tier-2 > a {
display: block;
- padding: .5em 1.5em .4em 1em;
+ padding: 0.5em 1.5em 0.4em 1em;
@birkenfeld
birkenfeld added a line comment Feb 25, 2014

these changes appear unrelated?

@benjaminp
benjaminp added a line comment Feb 25, 2014

Every css file is generated from a .scss file.

@birkenfeld
birkenfeld added a line comment Feb 25, 2014

So you have a different sass version that generates slightly different CSS?

@benjaminp
benjaminp added a line comment Feb 25, 2014

Apparently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@birkenfeld

Does this leave the small button on the right with instructions about this tracker?

@benjaminp

Nope.

@birkenfeld

Do we want to leave it there? :)

@benjaminp

Note that the current doodad only serves to open the feedback form on the bottom of the page, so we'd have to make some changes to it to provide "instructions about this tracker". IMO, we should just link to the tracker from the bottom of every page of from the /about/help page.

@birkenfeld

Agreed.

@benjaminp benjaminp merged commit 776bf6d into python:master Feb 25, 2014

1 check passed

Details default The Travis CI build passed
@benjaminp benjaminp deleted the benjaminp:rm-feedback branch Feb 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment