Add EOL banner to EOL downloads #2832
Open
+274
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…improve contrast ratio to meet WCAG AA guidelines
hugovk
force-pushed
the
eol-warning-banner
branch
from
410bb8c to
b8c3d3f
Compare
hugovk
added
app/downloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We look up the release status and EOL date from https://peps.python.org/api/python-releases.json and cache it.
That API only has data back to 1.6, and we only have releases back to 2.0, so we're covered.
I used the existing red
.user-feedback.level-errorCSS, and adjust the "Warning:" and link colours to meet the WCAG AA guidelines for contrast ratio.I also switched the superseded-by note added in #2827 to use the yellow
.user-feedback.level-noticeand fixed the contrast for "Note:".Both banners:
Only the EOL banner:
Only the superseded by banner:
And this is how the contrast looked before (3.30, 3.45 and 2.02 respectively, now 5.53, 5.10, and 6.06):