Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to the test suite #81

Open
brettcannon opened this issue Jan 21, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@brettcannon
Copy link
Member

commented Jan 21, 2017

Adding type hints throughout the test suite would help make sure that the various fake objects actually met the type restrictions of what they were faking. The real trick is cleaning up test code that's taking shortcuts where changing the type hints to match the test suite would weaken the type checks (e.g. making things Optional just because None was used in the test suite to be lazy).

  • ni.test.util
  • ni.test.test_bpo
  • ni.test.test_github
  • ni.test.test_heroku
  • ni.test.test_main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.