Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dimensions for openpyxl Image. #12362

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

noamkush
Copy link
Contributor

Image has height and width set in the constructor, but they are missing from the stub.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 6b919d7 into python:main Jul 18, 2024
48 checks passed
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@noamkush noamkush deleted the openpyxl-image-dimensions branch July 18, 2024 10:29
max-muoto pushed a commit to max-muoto/typeshed that referenced this pull request Jul 23, 2024
max-muoto pushed a commit to max-muoto/typeshed that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants