New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv DictReader should only yield OrderedDicts in Py3.6 #1478

Merged
merged 1 commit into from Jul 15, 2017

Conversation

Projects
None yet
2 participants
@graingert
Contributor

graingert commented Jul 11, 2017

No description provided.

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Jul 11, 2017

Contributor

although of course this is still wrong

out of the box DictReader supports returning floats and strings
restkey should be a generic type var of any hashable
restvar should be a generic type of any var

Contributor

graingert commented Jul 11, 2017

although of course this is still wrong

out of the box DictReader supports returning floats and strings
restkey should be a generic type var of any hashable
restvar should be a generic type of any var

Show outdated Hide outdated stdlib/2and3/csv.pyi
restkey: Optional[str] = ..., restval: Optional[str] = ..., dialect: _Dialect = ...,
*args: Any, **kwds: Any) -> None: ...
def __iter__(self) -> 'DictReader': ...
def __next__(self) -> _DRMapping: ...

This comment has been minimized.

@JelleZijlstra

JelleZijlstra Jul 11, 2017

Collaborator

This is redundant, you have __next__ below.

@JelleZijlstra

JelleZijlstra Jul 11, 2017

Collaborator

This is redundant, you have __next__ below.

This comment has been minimized.

@graingert

graingert Jul 11, 2017

Contributor

oh woops

@graingert

graingert Jul 11, 2017

Contributor

oh woops

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Jul 11, 2017

Contributor

@JelleZijlstra ok, done

Contributor

graingert commented Jul 11, 2017

@JelleZijlstra ok, done

@JelleZijlstra JelleZijlstra merged commit 2bb7ea9 into python:master Jul 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gvanrossum gvanrossum referenced this pull request Jul 22, 2017

Closed

Release mypy 0.521 #3732

gvanrossum added a commit to gvanrossum/mypy that referenced this pull request Jul 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment