Fix some bugs in xml.etree.ElementTree.Element's container behavior. #1816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rchen152
commented
Jan 5, 2018
rchen152
commented
- Have Element inherit from MutableSequence, which is more precise than Sequence.
- Remove unnecessary inherited methods (e.g., getitem).
- Correct extend() to take an Iterable. (Sequence was too specific.)
- Alphabetize the typing imports, for sanity.
rowillia
pushed a commit
to rowillia/typeshed
that referenced
this pull request
Feb 27, 2018
The methods removed by python#1816 are abstract in `MutableSequence` and therefore must be specified on `Element`.
JelleZijlstra
pushed a commit
that referenced
this pull request
Feb 27, 2018
The methods removed by #1816 are abstract in `MutableSequence` and therefore must be specified on `Element`.
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
The methods removed by python#1816 are abstract in `MutableSequence` and therefore must be specified on `Element`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.