Skip to content

Fix instantiating a xml.etree.ElementTree.Element #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 4 commits into from
Feb 27, 2018
Merged

Fix instantiating a xml.etree.ElementTree.Element #1930

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20ce237
Fix instantiating a xml.etree.ElementTree.Element
Feb 27, 2018
1265d86
Fix overloads, ensure Element can be created
Feb 27, 2018
16d09c7
Use for instead of overload
Feb 27, 2018
e5861bc
Remove creating an Element as it breaks pytype
Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion stdlib/2and3/xml/etree/ElementTree.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Stubs for xml.etree.ElementTree

from typing import Any, Callable, Dict, Generator, IO, ItemsView, Iterable, Iterator, KeysView, List, MutableSequence, Optional, Sequence, Text, Tuple, TypeVar, Union
from typing import Any, Callable, Dict, Generator, IO, ItemsView, Iterable, Iterator, KeysView, List, MutableSequence, Optional, overload, Sequence, Text, Tuple, TypeVar, Union
import io
import sys

Expand Down Expand Up @@ -70,6 +70,17 @@ class Element(MutableSequence['Element']):
def remove(self, subelement: 'Element') -> None: ...
def set(self, key: _str_argument_type, value: _str_argument_type) -> None: ...
def __bool__(self) -> bool: ...
def __delitem__(self, i: Union[int, slice]) -> None: ...
@overload
def __getitem__(self, i: int) -> 'Element': ...
@overload
def __getitem__(self, s: slice) -> Sequence['Element']: ...
def __len__(self) -> int: ...
@overload
def __setitem__(self, i: int, o: 'Element') -> None: ...
@overload
def __setitem__(self, s: slice, o: Iterable['Element']) -> None: ...


def SubElement(parent: Element, tag: _str_argument_type, attrib: Dict[_str_argument_type, _str_argument_type]=..., **extra: _str_argument_type) -> Element: ...
def Comment(text: _str_argument_type=...) -> Element: ...
Expand Down