urlretrieve can accept filename: pathlib.Path for Python>=3.6 #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib/3/urllib/request.pyi
Outdated
| @@ -188,7 +189,7 @@ class HTTPErrorProcessor(BaseHandler): | |||
| def https_response(self) -> _UrlopenRet: ... | |||
|
|
|||
|
|
|||
| def urlretrieve(url: str, filename: Optional[str] = ..., | |||
| def urlretrieve(url: str, filename: Optional[Union[str, Path]] = ..., | |||
There was a problem hiding this comment.
Can you add a version check if sys.version_info >= (3, 6): and allow os.PathLike[str] instead of just pathlib.Path?
|
Thanks, and when I copy these changes into my own Python install, the original error message is no longer issued for my own .py code. |
JelleZijlstra
approved these changes
Jun 5, 2018
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Python >= 3.6,
urllib.request.urlretrieve()can accept argumentfilename=strorpathlib.Path, this Pull Request is intended to allow type checkers to acknowledge this fact.This was prompted by MyPy 0.600 giving error:
when passing a
pathlib.Pathfilename.