Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing explicit Optional to stubs for the xml.etree package. #2734

Merged
merged 2 commits into from Jan 17, 2019

Conversation

Projects
None yet
2 participants
@mrshannon
Copy link
Contributor

commented Jan 10, 2019

This fixes #2733 as well as making Optional explicit for the rest of the xml.etree package as per the guidelines on implicit vs. explicit Optional for None defaults.

@srittau
Copy link
Collaborator

left a comment

Thank you!

@srittau srittau merged commit a2ecfaf into python:master Jan 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.