Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: inherit TimedRotatingFileHandler from Handler #2738

Merged
merged 1 commit into from Jan 17, 2019

Conversation

Projects
None yet
2 participants
@longedok
Copy link
Contributor

commented Jan 11, 2019

I've noticed that the stub for TimedRotatingFileHandler from logging.handlers module does not inherit from the base Handler class in python 2 case, which causes mypy to report errors when, for example, you try to add an instance of this handler to a logger.

@srittau
Copy link
Collaborator

left a comment

Thank you! TimedRotatingFileHandler actually derives from BaseRotatingHandler, like it does in Python 3. but since that is not in the Python 2 version either, this would require larger changes.

@srittau srittau merged commit 6f09ccb into python:master Jan 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.