Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create stubs for Flask #2740

Merged
merged 3 commits into from Jan 30, 2019

Conversation

Projects
None yet
2 participants
@pcorpet
Copy link
Contributor

commented Jan 14, 2019

See permission in pallets/flask#2012.

Fixes #28.

@pcorpet pcorpet force-pushed the pcorpet:flask branch from 1a39955 to 0b77ce1 Jan 14, 2019

@pcorpet pcorpet force-pushed the pcorpet:flask branch from 0b77ce1 to aa52197 Jan 14, 2019

@ilevkivskyi
Copy link
Contributor

left a comment

I am not a Flask user, but I discovered couple hundreds possible false positives when trying these stubs with our internal codebase. 95% of them however fall into few categories below.

@JelleZijlstra @srittau Could one of you please also take a look at this PR?

Show resolved Hide resolved third_party/2and3/flask/globals.pyi Outdated
Show resolved Hide resolved third_party/2and3/flask/app.pyi
Show resolved Hide resolved third_party/2and3/flask/views.pyi
Show resolved Hide resolved third_party/2and3/flask/globals.pyi
Show resolved Hide resolved third_party/2and3/flask/globals.pyi
Show resolved Hide resolved third_party/2and3/flask/app.pyi

@pcorpet pcorpet force-pushed the pcorpet:flask branch from d252fee to e9c2028 Jan 28, 2019

@ilevkivskyi
Copy link
Contributor

left a comment

This is almost ready. You just need to add the metaclass, and two comments.

Show resolved Hide resolved third_party/2and3/flask/app.pyi
Show resolved Hide resolved third_party/2and3/werkzeug/wrappers.pyi

@pcorpet pcorpet force-pushed the pcorpet:flask branch from e9c2028 to fb01ccb Jan 30, 2019

@ilevkivskyi
Copy link
Contributor

left a comment

Thanks! LGTM now.

@ilevkivskyi

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2019

@srittau @JelleZijlstra If there are no objections, I will merge this soon, so that we can move forward.

@ilevkivskyi ilevkivskyi merged commit 75581cf into python:master Jan 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@macbeth322 macbeth322 referenced this pull request Feb 11, 2019

Closed

Flask app Protocol #2789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.