Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orjson.pyi #2747

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
3 participants
@ijl
Copy link
Contributor

commented Jan 18, 2019

Per #2743.


from typing import Any, Callable, Optional, Union

def dumps(obj: Any, default=Optional[Callable[Any]]) -> bytes: ...

This comment has been minimized.

Copy link
@JelleZijlstra

JelleZijlstra Jan 18, 2019

Collaborator

I think you mixed up the default and the type here.

This comment has been minimized.

Copy link
@ijl

ijl Jan 18, 2019

Author Contributor

Fixed, I think, thanks.

@ijl

This comment has been minimized.

Copy link
Contributor Author

commented Jan 22, 2019

@JelleZijlstra and maintainers, could you look again?

@ijl

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

I've updated this to the match the latest upstream. Could a maintainer please take a look?

@srittau
Copy link
Collaborator

left a comment

Very interesting to see rust being used for Python. I have two small comments/questions below.

Show resolved Hide resolved third_party/3/orjson.pyi
Show resolved Hide resolved third_party/3/orjson.pyi Outdated

@srittau srittau merged commit 9bbe609 into python:master Feb 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ijl ijl deleted the ijl:orjson branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.