Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the errors arg in codecs factory functions. #2752

Merged
merged 1 commit into from Feb 9, 2019

Conversation

Projects
None yet
2 participants
@aaugustin
Copy link
Contributor

commented Jan 19, 2019

When mypy sees this code:

codecs.getincrementaldecoder("utf-8")(errors="strict")

It triggers this spurious error:

Unexpected keyword argument "errors"

This PR fixes that problem.

@srittau

srittau approved these changes Feb 9, 2019

Copy link
Collaborator

left a comment

Sorry for the late review and thank you for the fix!

@srittau srittau merged commit 0b6d134 into python:master Feb 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aaugustin

This comment has been minimized.

Copy link
Contributor Author

commented Feb 9, 2019

No problem, I just # type : ignore'd it in the meantime :-) Thanks for maintaining typeshed!

@aaugustin aaugustin deleted the aaugustin:codecs-errors branch Feb 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.