Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the stubs in charset.pyi under python3. #2768

Merged
merged 2 commits into from Feb 9, 2019

Conversation

Projects
None yet
2 participants
@joshuamorton
Copy link
Contributor

commented Jan 25, 2019

The python3 charset stubs didn't include certain necessary module level
constansts (like QP) and too-tightly defined the arguments to some of
the functions in the module. This is no longer the case.

Fixes #2767.

Joshua Morton added some commits Jan 25, 2019

Joshua Morton
Improve the stubs in charset.pyi under python3.
The python3 charset stubs didn't include certain necessary module level
constansts (like `QP`) and too-tightly defined the arguments to some of
the functions in the module. This is no longer the case.
Joshua Morton
Update add_charset to only take a string.
On a second look, add_charset only accepts a string, it doesn't
stringify the accepted object, so a Charset won't function correctly.
@srittau

srittau approved these changes Feb 9, 2019

Copy link
Collaborator

left a comment

Thank you!

@srittau srittau merged commit b0eb6c2 into python:master Feb 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.