Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing annotations in cyaml #2769

Merged
merged 2 commits into from Feb 17, 2019

Conversation

Projects
None yet
2 participants
@Hanaasagi
Copy link
Contributor

commented Jan 26, 2019

This pull request wants to resolve #2665. There are some details:

  • CDangerLoader and CDangerDumper is not showed in document. So I add # undocumented comment.

  • CEmitter is defined in Cython extension file _yaml.pyx#L935. Some variables like canonical is just used as a condition, I think it can be any type.

if canonical:
    yaml_emitter_set_canonical(&self.emitter, 1)
@rchen152
Copy link
Collaborator

left a comment

Thank you for the documentation and source code links; they were very helpful! Some comments inline.

Show resolved Hide resolved third_party/2and3/yaml/cyaml.pyi Outdated
Show resolved Hide resolved third_party/2and3/yaml/cyaml.pyi Outdated
Show resolved Hide resolved third_party/2and3/yaml/cyaml.pyi Outdated
Show resolved Hide resolved third_party/2and3/yaml/cyaml.pyi
Show resolved Hide resolved third_party/2and3/yaml/cyaml.pyi Outdated
@rchen152
Copy link
Collaborator

left a comment

Thank you!

@rchen152 rchen152 merged commit 570fd6a into python:master Feb 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.