Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Define functools.partial as overloaded function instead of its own class" #3077

Merged
merged 1 commit into from Jun 21, 2019

Conversation

@JelleZijlstra
Copy link
Collaborator

commented Jun 20, 2019

Reverts #2878

Caused problems in many real-world codebases. Proper support for partial will have to come from a plugin instead.

I've seen the following problems reported:

  • Keyword arguments to partial() functions no longer work
  • isinstance() checks on functools.partial no longer work
  • Access to .func and other attributes no longer works

@JelleZijlstra JelleZijlstra requested review from srittau and JukkaL Jun 20, 2019

@JelleZijlstra JelleZijlstra merged commit ada0570 into master Jun 21, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@JelleZijlstra JelleZijlstra deleted the revert-2878-overloaded_partial branch Jun 21, 2019

@gvanrossum gvanrossum referenced this pull request Jun 21, 2019

JelleZijlstra added a commit that referenced this pull request Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.