Expand tokenize stub to include Intnumber etc #3839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
requested changes
Mar 11, 2020
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thanks! Left a few comments
stdlib/3/tokenize.pyi
Outdated
| def compat(self, token: Sequence[Union[int, str]], iterable: Iterable[_Token]) -> None: ... | ||
|
|
||
| def untokenize(iterable: Iterable[_Token]) -> Any: ... | ||
| def untokenize(iterable: Iterable[_Token]) -> bytes: ... |
Member
There was a problem hiding this comment.
I haven't tried but I think this returns a str if there is no ENCODING token in the input.
Contributor
Author
There was a problem hiding this comment.
You're right. I looked again; the docstring is wrong. Would you like this Union[str, bytes] instead of Any?
Member
There was a problem hiding this comment.
Any is fine, we generally avoid Union return types.
Contributor
Author
|
PTAL |
JelleZijlstra
approved these changes
Mar 11, 2020
Member
|
There's a stubtest failure—apparently a couple of constants are dicts instead of sets in 3.5. |
The all uppercase tokens, as well as tok_name mentioned in the comment actually come from the `from token import *`.
rchen152
added a commit
that referenced
this pull request
May 17, 2020
These constants were removed in #3839 because they are imported from token. However, that is only true in Python 3.7+.
JelleZijlstra
pushed a commit
that referenced
this pull request
May 18, 2020
These constants were removed in #3839 because they are imported from token. However, that is only true in Python 3.7+.
vishalkuo
pushed a commit
to vishalkuo/typeshed
that referenced
this pull request
Jun 26, 2020
These constants were removed in python#3839 because they are imported from token. However, that is only true in Python 3.7+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The all uppercase tokens, as well as
tok_namementioned in the commentactually come from the
from token import *.The LibCST project uses constants like
Intnumberin its parsing, https://github.com/Instagram/LibCST/blob/master/libcst/_parser/conversions/expression.py